fix(test): Disables spotlight for sample app by antonis · Pull Request #5266 · getsentry/sentry-react-native

antonis · 2025-10-14T12:30:12Z

📢 Type of change

Bugfix
New feature
Enhancement
Refactoring

📜 Description

Fixes contains exactly two articles requests spans test failure

💡 Motivation and Context

Consistent test failure (example) due to the localhost request spans

💚 How did you test it?

CI

📝 Checklist

I added tests to verify changes
No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
I updated the docs if needed.
I updated the wizard if needed.
All tests passing
No breaking changes

🔮 Next steps

#skip-changelog

github-actions · 2025-10-14T12:46:24Z

Android (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	368.26 ms	367.17 ms	-1.09 ms
Size	17.75 MiB	19.70 MiB	1.96 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`ba75c7c`	367.72 ms	369.16 ms	1.44 ms
`459a438`+dirty	417.09 ms	406.52 ms	-10.57 ms
`d751a5d`+dirty	434.24 ms	486.08 ms	51.84 ms
`2adbd1e`+dirty	433.98 ms	427.96 ms	-6.02 ms
`23080e5`	384.85 ms	382.57 ms	-2.28 ms
`20daa0a`	359.51 ms	374.90 ms	15.39 ms
`af9331b`	449.77 ms	479.20 ms	29.43 ms
`161947d`+dirty	393.26 ms	403.00 ms	9.74 ms
`64cd15c`	439.02 ms	427.63 ms	-11.39 ms
`77061ed`+dirty	369.55 ms	408.35 ms	38.80 ms

App size

Revision	Plain	With Sentry	Diff
`ba75c7c`	17.75 MiB	20.15 MiB	2.41 MiB
`459a438`+dirty	17.75 MiB	19.70 MiB	1.95 MiB
`d751a5d`+dirty	17.75 MiB	19.68 MiB	1.94 MiB
`2adbd1e`+dirty	17.75 MiB	19.70 MiB	1.96 MiB
`23080e5`	17.75 MiB	19.68 MiB	1.94 MiB
`20daa0a`	17.75 MiB	20.15 MiB	2.41 MiB
`af9331b`	17.75 MiB	19.68 MiB	1.94 MiB
`161947d`+dirty	17.75 MiB	19.70 MiB	1.95 MiB
`64cd15c`	17.75 MiB	20.15 MiB	2.41 MiB
`77061ed`+dirty	17.75 MiB	19.68 MiB	1.94 MiB

Previous results on branch: antonis/fix-captureSpaceflightNews-article-spans

Startup times

Revision	Plain	With Sentry	Diff
`24a5a84`+dirty	400.29 ms	394.81 ms	-5.48 ms
`e20920d`+dirty	376.02 ms	373.11 ms	-2.91 ms
`fd93bb6`+dirty	423.92 ms	422.38 ms	-1.54 ms

App size

Revision	Plain	With Sentry	Diff
`24a5a84`+dirty	17.75 MiB	19.70 MiB	1.95 MiB
`e20920d`+dirty	17.75 MiB	19.70 MiB	1.96 MiB
`fd93bb6`+dirty	17.75 MiB	19.70 MiB	1.95 MiB

antonis · 2025-10-14T12:49:03Z

@lucas-zimerman I think the new spans are related to the consoleLoggingIntegration. If that is the case do we need any other modifications or fixing the tests is enough?

github-actions · 2025-10-14T12:59:46Z

Android (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	362.17 ms	411.68 ms	49.51 ms
Size	7.15 MiB	8.43 MiB	1.28 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`459a438`+dirty	359.50 ms	390.53 ms	31.03 ms
`5526494`+dirty	380.79 ms	432.70 ms	51.91 ms
`d751a5d`+dirty	341.61 ms	403.06 ms	61.45 ms
`2adbd1e`+dirty	366.13 ms	419.49 ms	53.36 ms
`161947d`+dirty	349.27 ms	435.09 ms	85.82 ms
`77061ed`+dirty	359.40 ms	424.10 ms	64.70 ms
`bfe454a`+dirty	372.42 ms	424.52 ms	52.10 ms
`c1573b3`+dirty	355.65 ms	448.82 ms	93.17 ms
`af9331b`+dirty	374.42 ms	425.68 ms	51.26 ms
`23080e5`+dirty	347.29 ms	381.87 ms	34.58 ms

App size

Revision	Plain	With Sentry	Diff
`459a438`+dirty	7.15 MiB	8.42 MiB	1.27 MiB
`5526494`+dirty	7.15 MiB	8.41 MiB	1.26 MiB
`d751a5d`+dirty	7.15 MiB	8.41 MiB	1.26 MiB
`2adbd1e`+dirty	7.15 MiB	8.43 MiB	1.28 MiB
`161947d`+dirty	7.15 MiB	8.43 MiB	1.28 MiB
`77061ed`+dirty	7.15 MiB	8.41 MiB	1.26 MiB
`bfe454a`+dirty	7.15 MiB	8.42 MiB	1.26 MiB
`c1573b3`+dirty	7.15 MiB	8.42 MiB	1.27 MiB
`af9331b`+dirty	7.15 MiB	8.41 MiB	1.26 MiB
`23080e5`+dirty	7.15 MiB	8.41 MiB	1.26 MiB

Previous results on branch: antonis/fix-captureSpaceflightNews-article-spans

Startup times

Revision	Plain	With Sentry	Diff
`24a5a84`+dirty	325.32 ms	361.80 ms	36.48 ms
`e20920d`+dirty	382.33 ms	435.17 ms	52.83 ms
`fd93bb6`+dirty	369.69 ms	375.85 ms	6.15 ms

App size

Revision	Plain	With Sentry	Diff
`24a5a84`+dirty	7.15 MiB	8.43 MiB	1.28 MiB
`e20920d`+dirty	7.15 MiB	8.43 MiB	1.28 MiB
`fd93bb6`+dirty	7.15 MiB	8.43 MiB	1.28 MiB

github-actions · 2025-10-14T13:07:54Z

iOS (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1220.65 ms	1224.77 ms	4.12 ms
Size	2.63 MiB	4.00 MiB	1.36 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`0b64753`+dirty	1232.49 ms	1226.96 ms	-5.53 ms
`93137d1`+dirty	1230.73 ms	1230.98 ms	0.25 ms
`7480abe`+dirty	1220.53 ms	1244.18 ms	23.65 ms
`23080e5`+dirty	1216.02 ms	1224.94 ms	8.91 ms
`3bd3f0d`+dirty	1231.51 ms	1229.10 ms	-2.41 ms
`59f3a84`+dirty	1232.56 ms	1238.12 ms	5.56 ms
`eb07ba3`+dirty	1222.46 ms	1220.37 ms	-2.08 ms
`6479fd5`+dirty	1228.48 ms	1231.32 ms	2.84 ms
`c7f264b`+dirty	1211.82 ms	1218.04 ms	6.22 ms
`ba75c7c`+dirty	1235.86 ms	1226.45 ms	-9.41 ms

App size

Revision	Plain	With Sentry	Diff
`0b64753`+dirty	2.63 MiB	3.98 MiB	1.35 MiB
`93137d1`+dirty	2.63 MiB	3.99 MiB	1.35 MiB
`7480abe`+dirty	2.63 MiB	3.96 MiB	1.33 MiB
`23080e5`+dirty	2.63 MiB	3.91 MiB	1.28 MiB
`3bd3f0d`+dirty	2.63 MiB	3.99 MiB	1.35 MiB
`59f3a84`+dirty	2.63 MiB	3.99 MiB	1.36 MiB
`eb07ba3`+dirty	2.63 MiB	3.81 MiB	1.18 MiB
`6479fd5`+dirty	2.63 MiB	3.96 MiB	1.33 MiB
`c7f264b`+dirty	2.63 MiB	3.91 MiB	1.28 MiB
`ba75c7c`+dirty	2.63 MiB	3.81 MiB	1.18 MiB

Previous results on branch: antonis/fix-captureSpaceflightNews-article-spans

Startup times

Revision	Plain	With Sentry	Diff
`e20920d`+dirty	1225.78 ms	1235.38 ms	9.60 ms
`24a5a84`+dirty	1233.33 ms	1239.04 ms	5.72 ms
`fd93bb6`+dirty	1221.60 ms	1242.33 ms	20.73 ms

App size

Revision	Plain	With Sentry	Diff
`e20920d`+dirty	2.63 MiB	4.00 MiB	1.36 MiB
`24a5a84`+dirty	2.63 MiB	3.99 MiB	1.36 MiB
`fd93bb6`+dirty	2.63 MiB	4.00 MiB	1.36 MiB

github-actions · 2025-10-14T13:29:49Z

iOS (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1242.83 ms	1253.16 ms	10.33 ms
Size	3.19 MiB	4.56 MiB	1.38 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`0b64753`+dirty	1225.77 ms	1232.98 ms	7.21 ms
`93137d1`+dirty	1232.69 ms	1245.18 ms	12.49 ms
`7480abe`+dirty	1219.84 ms	1223.60 ms	3.76 ms
`23080e5`+dirty	1221.39 ms	1222.08 ms	0.70 ms
`3bd3f0d`+dirty	1230.18 ms	1243.41 ms	13.22 ms
`59f3a84`+dirty	1205.09 ms	1213.31 ms	8.23 ms
`eb07ba3`+dirty	1214.49 ms	1221.59 ms	7.10 ms
`6479fd5`+dirty	1207.80 ms	1215.12 ms	7.32 ms
`c7f264b`+dirty	1229.78 ms	1225.84 ms	-3.94 ms
`ba75c7c`+dirty	1236.14 ms	1240.69 ms	4.55 ms

App size

Revision	Plain	With Sentry	Diff
`0b64753`+dirty	3.19 MiB	4.55 MiB	1.36 MiB
`93137d1`+dirty	3.19 MiB	4.55 MiB	1.37 MiB
`7480abe`+dirty	3.19 MiB	4.53 MiB	1.35 MiB
`23080e5`+dirty	3.19 MiB	4.48 MiB	1.29 MiB
`3bd3f0d`+dirty	3.19 MiB	4.55 MiB	1.37 MiB
`59f3a84`+dirty	3.19 MiB	4.56 MiB	1.37 MiB
`eb07ba3`+dirty	3.19 MiB	4.38 MiB	1.19 MiB
`6479fd5`+dirty	3.19 MiB	4.53 MiB	1.35 MiB
`c7f264b`+dirty	3.19 MiB	4.48 MiB	1.29 MiB
`ba75c7c`+dirty	3.19 MiB	4.38 MiB	1.19 MiB

Previous results on branch: antonis/fix-captureSpaceflightNews-article-spans

Startup times

Revision	Plain	With Sentry	Diff
`e20920d`+dirty	1233.86 ms	1233.58 ms	-0.27 ms
`24a5a84`+dirty	1234.16 ms	1232.79 ms	-1.38 ms
`fd93bb6`+dirty	1213.04 ms	1215.31 ms	2.27 ms

App size

Revision	Plain	With Sentry	Diff
`e20920d`+dirty	3.19 MiB	4.56 MiB	1.38 MiB
`24a5a84`+dirty	3.19 MiB	4.56 MiB	1.37 MiB
`fd93bb6`+dirty	3.19 MiB	4.56 MiB	1.38 MiB

lucas-zimerman · 2025-10-14T16:36:59Z

@lucas-zimerman I think the new spans are related to the consoleLoggingIntegration. If that is the case do we need any other modifications or fixing the tests is enough?

That's the spotlight URL, we are probably instrumenting requests being sent to spotlight :O

antonis · 2025-10-15T07:28:57Z

That's the spotlight URL, we are probably instrumenting requests being sent to spotlight

Good point @lucas-zimerman 👍 I haven't figured out why this started now 🤔

lucas-zimerman · 2025-10-15T09:54:22Z

That's the spotlight URL, we are probably instrumenting requests being sent to spotlight

Good point @lucas-zimerman 👍 I haven't figured out why this started now 🤔

Can we disable spotlight there?

…pans

This reverts commit c48dd54.

antonis · 2025-10-15T10:08:02Z

Can we disable spotlight there?

Testing this with ba431c6 🤞

This reverts commit ba431c6.

This reverts commit 3cf86e4.

antonis · 2025-10-15T14:05:45Z

The api we are using seems to not be available at this point. I'll retest tomorrow
https://api.spaceflightnewsapi.net/v4/docs

…pans

… count"" This reverts commit 4d20d44.

This reverts commit aec7a98.

antonis · 2025-10-16T13:07:42Z

Can we disable spotlight there?

Disabling spotlight seems to be working. Thank you @lucas-zimerman 🙇
I still haven't figured out why this didn't affect the test before Oct 14. But it's something we can look into separately.

…pans

lucas-zimerman

LGTM!

fix(test): Exclude localhost requests from HTTP span count

c48dd54

antonis marked this pull request as ready for review October 14, 2025 13:45

antonis requested review from alwx and lucas-zimerman as code owners October 14, 2025 13:45

antonis mentioned this pull request Oct 15, 2025

fix(metro): Unpin Metro 0.83.2 from E2E tests #5269

Merged

10 tasks

antonis added 3 commits October 15, 2025 12:05

Merge branch 'main' into antonis/fix-captureSpaceflightNews-article-s…

c44aa21

…pans

Revert "fix(test): Exclude localhost requests from HTTP span count"

3cf86e4

This reverts commit c48dd54.

Disable spotlight in the sample

ba431c6

antonis added 2 commits October 15, 2025 13:37

Revert "Disable spotlight in the sample"

aec7a98

This reverts commit ba431c6.

Reapply "fix(test): Exclude localhost requests from HTTP span count"

4d20d44

This reverts commit 3cf86e4.

antonis marked this pull request as draft October 15, 2025 11:38

antonis added 3 commits October 16, 2025 14:11

Merge branch 'main' into antonis/fix-captureSpaceflightNews-article-s…

738ac73

…pans

Revert "Reapply "fix(test): Exclude localhost requests from HTTP span…

e8f08ae

… count"" This reverts commit 4d20d44.

Reapply "Disable spotlight in the sample"

e547ff5

This reverts commit aec7a98.

antonis changed the title ~~fix(test): Exclude localhost requests from HTTP span count~~ fix(test): Disables spotlight for sample app Oct 16, 2025

antonis marked this pull request as ready for review October 16, 2025 13:07

Merge branch 'main' into antonis/fix-captureSpaceflightNews-article-s…

b77b1f3

…pans

lucas-zimerman approved these changes Oct 20, 2025

View reviewed changes

alwx approved these changes Oct 20, 2025

View reviewed changes

antonis merged commit d861c16 into main Oct 20, 2025
108 of 114 checks passed

antonis deleted the antonis/fix-captureSpaceflightNews-article-spans branch October 20, 2025 11:08

Uh oh!

Conversation

antonis commented Oct 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📢 Type of change

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

🔮 Next steps

Uh oh!

github-actions bot commented Oct 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Android (legacy) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: antonis/fix-captureSpaceflightNews-article-spans

Startup times

App size

Uh oh!

antonis commented Oct 14, 2025

Uh oh!

github-actions bot commented Oct 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Android (new) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: antonis/fix-captureSpaceflightNews-article-spans

Startup times

App size

Uh oh!

github-actions bot commented Oct 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

iOS (legacy) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: antonis/fix-captureSpaceflightNews-article-spans

Startup times

App size

Uh oh!

github-actions bot commented Oct 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

iOS (new) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: antonis/fix-captureSpaceflightNews-article-spans

Startup times

App size

Uh oh!

lucas-zimerman commented Oct 14, 2025

Uh oh!

antonis commented Oct 15, 2025

Uh oh!

lucas-zimerman commented Oct 15, 2025

Uh oh!

antonis commented Oct 15, 2025

Uh oh!

antonis commented Oct 15, 2025

Uh oh!

antonis commented Oct 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lucas-zimerman left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

antonis commented Oct 14, 2025 •

edited

Loading

github-actions bot commented Oct 14, 2025 •

edited

Loading

github-actions bot commented Oct 14, 2025 •

edited

Loading

github-actions bot commented Oct 14, 2025 •

edited

Loading

github-actions bot commented Oct 14, 2025 •

edited

Loading

antonis commented Oct 16, 2025 •

edited

Loading